Skip to content

Settings design polishing#10480

Merged
rullzer merged 9 commits into
masterfrom
bugfix/10420/settings
Aug 2, 2018
Merged

Settings design polishing#10480
rullzer merged 9 commits into
masterfrom
bugfix/10420/settings

Conversation

@juliusknorr

@juliusknorr juliusknorr commented Aug 1, 2018

Copy link
Copy Markdown
Member

From #10094

  • User management: Table headers should be lighter font color than the rest of the text
  • External storages: Could use a settings-hint text like "You can mount different storage services as folders into your Nextcloud." Global credentials also needs explanation
  • External storages: Settings menu should use 3-dot-icon, and delete action should go in there too (as last entry)
  • Personal info: Vertical whitespace is a bit much. If it's cause of the region format, put time and date on one row.
  • Merge Server-side encryption into "Security" section?
  • Groupware: "Calendar settings" instead of "CalDAV server", and more whitespace between settings.
  • Workflow: Create a new tag input field should also create the tag on pressing enter

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug design Design, UI, UX, etc. 3. to review Waiting for reviews papercut Annoying recurring UX issue with possibly simple fix. labels Aug 1, 2018
@juliusknorr juliusknorr added this to the Nextcloud 14 milestone Aug 1, 2018

@skjnldsv skjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rullzer
rullzer previously requested changes Aug 1, 2018

@rullzer rullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests fail

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr

Copy link
Copy Markdown
Member Author

@rullzer Unit tests fixed.

@skjnldsv

skjnldsv commented Aug 2, 2018

Copy link
Copy Markdown
Member

LGTM! 🛥️

@rullzer

rullzer commented Aug 2, 2018

Copy link
Copy Markdown
Member

@juliushaertl are you sure: https://drone.nextcloud.com/nextcloud/server/9390/251

@juliusknorr

Copy link
Copy Markdown
Member Author

@rullzer Sorry, missed that when scrolling though the drone report, I've just recognized the files-acceptance failure. 🙈 will fix

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@rullzer rullzer merged commit 01298cf into master Aug 2, 2018
@rullzer rullzer deleted the bugfix/10420/settings branch August 2, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. papercut Annoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants